Skip to content

Figure.pygmtlogo: Set the region based on wordmark for easier design#4634

Open
seisman wants to merge 8 commits into
pygmtlogofrom
pygmtlogo-wordmark-design
Open

Figure.pygmtlogo: Set the region based on wordmark for easier design#4634
seisman wants to merge 8 commits into
pygmtlogofrom
pygmtlogo-wordmark-design

Conversation

@seisman
Copy link
Copy Markdown
Member

@seisman seisman commented May 11, 2026

Currently, the region is set to [-4, 4, -4, 4]. The issues are:

  1. We need to use no_clip=True when adding the wordmark
  2. We can't adding debugging lines (gridlines) for wordmarks, so we can't control the size of the wordmark accurately.

This PR does three things:

  • sets the region based on wordmark, i.e., larger x-range for horizontal wordmark and larger y-range for vertical wordmark
  • slightly modifies the code for adding debugging lines to ensure the debugging lines are plotted inside the visual logo only
  • adds two baseline images for the logo design with horizontal/vertical wordmark. The orginal baseline image for a visual logo without a wordmark is no longer needed, because it's already covered by the two new baseline images.

Ideally, we should be able to remove the no_clip=True argument from the Figure.text call. But as you can see, the wordmark in the vertical version is slightly wider than the visual logo.

Edit: I've slightly decreased the font size for the vertical wordmark, and then remove the no_clip parameter from Figure.text.

Old version New version
image image

Please note that the design of wordmarks is still ongoing in PR #4627. So, this PR focuses on adding tests to make the wordmark design easier.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_pygmtlogo_circle_design_horizontal.png
added pygmt/tests/baseline/test_pygmtlogo_circle_design_vertical.png
deleted pygmt/tests/baseline/test_pygmtlogo_circle_design.png

Image diff(s)

Details

Added images

  • test_pygmtlogo_circle_design_horizontal.png

  • test_pygmtlogo_circle_design_vertical.png

Modified images

Path Old New

Report last updated at commit a076530

@seisman seisman added the maintenance Boring but important stuff for the core devs label May 11, 2026
@seisman seisman added this to the 0.19.0 milestone May 11, 2026
@seisman seisman added the needs review This PR has higher priority and needs review. label May 11, 2026
@seisman seisman requested a review from yvonnefroehlich May 11, 2026 03:35
Comment thread pygmt/src/pygmtlogo.py Outdated
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Comment thread pygmt/src/pygmtlogo.py Outdated
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman seisman deployed to pr-tests May 11, 2026 12:56 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants